balysv / material-ripple

Android L Ripple effect wrapper for Views
Apache License 2.0
2.36k stars 479 forks source link

The ripple SHOULDN'T follow the finger movement while holding #69

Open taylorling opened 7 years ago

taylorling commented 7 years ago

I am speaking as a designer here. We were using this library hoping to bring the ripple effect to pre-L devices, but I found out that the behavior is wrong in a sense that the ripple, when it happens, it should emit at the source of trigger, which shouldn't follow the finger when it is being tapped and hold.

Also the ripple should ensure that the four corners reach at the exact same time, this would mean when the ripple happens, the center point should also move so the 4 corners will meet the end at the exact same time.

These are the genuine behavior in Ripple effect in Material Design. Hopefully the author of the library can fix this to ensure everyone who is using this library is able to implement the right Material Design behavior.

Thanks!