search

bambanah / deemix

GNU General Public License v3.0
97 stars 7 forks source link

Set album and file extension before generating filename #107

Closed krankydonkey closed 2 months ago

krankydonkey commented 2 months ago

Edited downloader.js to move the parseData and selectedFormat calls to above the generatePath call.

changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: 172c33136531476561a9a0ff1d06003fd56c30d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

bambanah commented 2 months ago

The original motivation behind this behaviour was primarily for fast skipping tracks that are already downloaded since the parseData call is extremely expensive. Since I only download mp3 with basic %artist% - %title% format I didn't pick up on these issues.

File integrity definitely comes before speed, so will merge this and think of a much smarter way to skip downloads.