bambanah / deemix

GNU General Public License v3.0
97 stars 7 forks source link

Fix bitrate settings #121

Closed ericklucena closed 1 month ago

ericklucena commented 1 month ago

What?

Change settings page to store bitrate selection as a number

Why?

Currently, when saving the settings after making a selection in the dropdown, the value is stored as a string. The config file will be saved without errors. However, once the service is restarted, the property type will not match during verification (settings.ts::check) and will be reset to default value

How?

Minor change in the settings page to define the field mapping to use a number

Screenshots (if applicable)

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: f07ba07ac001f99cb38d55dda190d2a5047cf0d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------ | ----- | | deemix-webui | Patch | | deemix-gui | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR