Closed GStechschulte closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Merging #701 (8a4226a) into main (457eee3) will increase coverage by
0.16%
. The diff coverage is91.81%
.:exclamation: Current head 8a4226a differs from pull request most recent head 8847ad3. Consider uploading reports for the commit 8847ad3 to get more accurate results
@@ Coverage Diff @@
## main #701 +/- ##
==========================================
+ Coverage 89.57% 89.73% +0.16%
==========================================
Files 43 43
Lines 3522 3499 -23
==========================================
- Hits 3155 3140 -15
+ Misses 367 359 -8
Files Changed | Coverage Δ | |
---|---|---|
bambi/plots/plotting.py | 85.24% <88.88%> (+0.28%) |
:arrow_up: |
bambi/plots/effects.py | 90.94% <90.75%> (+1.69%) |
:arrow_up: |
bambi/plots/utils.py | 86.82% <92.98%> (+0.06%) |
:arrow_up: |
bambi/plots/__init__.py | 100.00% <100.00%> (ø) |
|
bambi/plots/create_data.py | 100.00% <100.00%> (ø) |
|
bambi/plots/plot_types.py | 73.39% <100.00%> (ø) |
... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
excellent work @GStechschulte. Just left some comments. I don't think further additions are needed, only some removals and maybe simplifications. Thanks a lot!
excellent work @GStechschulte. Just left some comments. I don't think further additions are needed, only some removals and maybe simplifications. Thanks a lot!
Thanks @tomicapretto , and also for the review!
This is fantastic!
This is fantastic!
Thank you @aloctavodia! And thanks for the feedback. Much appreciated :)
@GStechschulte there are some conflicts now :sweat_smile:
@aloctavodia if you don't have any further comments i will merge once the conflicts are resolved
@GStechschulte there are some conflicts now 😅
@aloctavodia if you don't have any further comments i will merge once the conflicts are resolved
Good to go now 😄
This PR provides documentation for PR #699 (
slopes
andplot_slopes
). The notebook provides the following sections:slopes
andplot_slopes
, and the benefits under the following: