search

bambinos / bambi

BAyesian Model-Building Interface (Bambi) in Python.
https://bambinos.github.io/bambi/
MIT License
1.08k stars 124 forks source link

Fix legend in EDA for Hierarchical baseball demo #770

Closed kddubey closed 10 months ago

kddubey commented 10 months ago

It looks like the legend labels in the EDA plot for the Hierarchical baseball demo are flipped.

Also, the current notebook explanation says that there were divergences when fitting the hierarchical model when there weren't any. This PR changes that explanation.

review-notebook-app[bot] commented 10 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (17a80c5) 89.83% compared to head (48eb3f8) 89.83%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #770 +/- ## ======================================= Coverage 89.83% 89.83% ======================================= Files 46 46 Lines 3809 3809 ======================================= Hits 3422 3422 Misses 387 387 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.