bambinos / bambi

BAyesian Model-Building Interface (Bambi) in Python.
https://bambinos.github.io/bambi/
MIT License
1.06k stars 121 forks source link

change os.rename to os.replace in pre-render.py #843

Closed DrEntropy closed 3 weeks ago

DrEntropy commented 3 weeks ago

Building the Bambi docs with quarto was giving a "file exists" error during pre-render while trying to rename "CHANGELOG.md" to "changelog.qmd". Simply changing os.rename to os.replace fixes this.

An alternative would be to add the CHANGELOG.md to the _quarto.yml explicitly (quarto can render md too)

tomicapretto commented 3 weeks ago

Building the Bambi docs with quarto was giving a "file exists" error during pre-render while trying to rename "CHANGELOG.md" to "changelog.qmd". Simply changing os.rename to os.replace fixes this.

An alternative would be to add the CHANGELOG.md to the _quarto.yml explicitly (quarto can render md too)

Thanks @DrEntropy for the contribution! I'll merge this once CI is green. Regarding Quarto, I'm aware we can add CHANGELOG.md to _quarto.yml. However, the last time I tried it, it was not working as expected. If I recall correctly, a non-rendered version of the file was being displayed in our webpage.

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.71%. Comparing base (038610c) to head (6e3ca83). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #843 +/- ## ========================================== - Coverage 89.82% 89.71% -0.11% ========================================== Files 47 47 Lines 3991 3997 +6 ========================================== + Hits 3585 3586 +1 - Misses 406 411 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.