Closed kddubey closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
9f81578
) 92.65% compared to head (e050737
) 92.68%. Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @kddubey! Thanks a lot for the PR. I'm writing to let you know that I see the contribution, but I still didn't have time to check the underlying issue very well. And I'm going to be travelling so I won't be able to check it for the next 2 weeks. Still, the code looks good and tests pass so that's great.
@tomicapretto No worries. And thank you to you and the PyMC team for building bambi
! It's a pleasure to explore and use. Happy travels :-)
@kddubey thanks a lot for the contribution :)
From https://pandas.pydata.org/docs/whatsnew/v2.1.0.html#other-deprecations:
Currently,
formulae
will surface this warning forpandas>=2.1.0
:(As of
pandas==2.1.4
this is aDeprecationWarning
instead of aFutureWarning
.)The change in this PR should be backwards-compatible.
How has this been tested?
In a virtual env w/
pandas==1.3.4
, I ranpytest
. I also checked that this snippet of code is correct.In a virtual env w/
pandas==2.1.4
, I ranpytest
. I also checked that the snippet of code above is still correct and doesn't raises a warning.