search

bambora / checkout-magento-v2.x

Bambora Online - Magento 2
https://www.bambora.com/sv/se/betalningslosningar/
3 stars 13 forks source link

Added module requirements to composer #23

Closed wexo-team closed 5 years ago

wexo-team commented 6 years ago

The lack of requirements gives problems with shops where unnecessary Magento modules has been removed, this change solves this by making the module describe what Magento modules it requires to function

Requirements are tested for compatibility with Magento 2.0, 2.1 and 2.2

AllanWLie commented 6 years ago

Hi @wexo-team

Thank you for your pull request. How does your changes to the composer file affect Magento 2 version support and does it affect "normal" Magento 2 installations ?

wexo-team commented 6 years ago

It do not change normal Magento 2 install when setup correct. It do add some more work to the repo owner that now have to update this modules dependency if a new Magento 2 version is released with major version number change (more info about Magento 2 versioning can be found here https://devdocs.magento.com/guides/v2.2/extension-dev-guide/versioning/)

In other words, it move the responsibility/work of checking up for compatibility with the latest Magento version from the shop owner over to the module developer

AllanWLie commented 5 years ago

Hi @wexo-team We have now tested your changes and we have merged your pull request. A new version of the module will be released soon.

Thank you for contributing to ours module and keep up the good work.

Best regards Allan - Bambora