search

bambulab / BambuStudio

PC Software for BambuLab and other 3D printers
GNU Affero General Public License v3.0
1.81k stars 253 forks source link

Sending gcode to a printer doesn't verify if that gcode was sliced for that printer model - you can send invalid gcode #2991

Open arekm opened 8 months ago

arekm commented 8 months ago

Bambu Studio Version

1.8.0.62

Where is the application from?

Bambu Lab github releases

OS version

All

Additional system information

Doesn't matter.

Printer

X1C

How to reproduce

  1. download gcode file: wilgotnosc 1.gcode.3mf.gz It is a file sliced for A1 printer, so wrong printer.
  2. decompress it
  3. go to bambu studio, open this file
  4. change from "Print" to "Send" to send this file to sd card
  5. choose X1C printer from the list
  6. click "Send"

Actual results

File is transferred to the printer without any problem.

What's worse later printer firmware doesn't verify that it was sliced for a different printer and you can start printing from it (with very bad results like head crashing into case etc).

Expected results

Expected result is Bambu Studio telling me "The selected printer is incompatible with the chosen printer presets". Exactly like it happens when we try to "Print" this file. Whether it should be possible to force sending such file to sdcard or not - that's open for discussion BUT big warning should be there.

Project file & Debug log uploads

wilgotnosc 1.gcode.3mf.gz

Checklist of files to include

walterwongbbl commented 8 months ago

Hi. @arekm Thank you very much, you are absolutely right. We only checked the compatibility between presets and printers during print job submission. We will plan to incorporate this change in the next version.

arekm commented 8 months ago

@walterwongbbl Great on Bambu Studio side.

But firmware also should check for compatibility (if someone puts sd card with files sliced for wrong printer and tries to print them).

No idea if bambu printers understand M862.3 (https://reprap.org/wiki/G-code#M862.3:_Model_name) but that could be used for this.

walterwongbbl commented 8 months ago

@walterwongbbl Great on Bambu Studio side.

But firmware also should check for compatibility (if someone puts sd card with files sliced for wrong printer and tries to print them).

No idea if bambu printers understand M862.3 (https://reprap.org/wiki/G-code#M862.3:_Model_name) but that could be used for this.

@sodachen22

BambulabRobot commented 2 weeks ago

This issue has been marked as inactive due to no response for 90 days.