bambuser / bambuser-livevideoshoppingplayer-sdk-ios

This SDK helps you add a Bambuser live shopping player to your UIKit and SwiftUI apps.
8 stars 2 forks source link

ITMS-90338: Non-public API usage #19

Open andyrevolve opened 1 year ago

andyrevolve commented 1 year ago

App got rejected by Apple with the following message (abbreviated):

The app references non-public symbols in Frameworks/BambuserLiveVideoShoppingPlayer.framework/BambuserLiveVideoShoppingPlayer: _CMTimebaseCopyMasterTimebase, _CMTimebaseCreateWithMasterClock, _CMTimebaseCreateWithMasterTimebase. If method names in your source code match the private Apple APIs listed above, altering your method names will help prevent this app from being flagged in future submissions.

Ran nm Frameworks/BambuserLiveVideoShoppingPlayer.framework/BambuserLiveVideoShoppingPlayer and found the above three symbols. Wondering if these deprecated APIs can be replaced with their updated counterpart.

Moein-Bam commented 1 year ago

@andyrevolve Thanks for the report! This will be fixed in the new release early next week.

arturonaredo commented 1 year ago

Hey @Moein-Bam ,

could you update us? We are forced to remove your SDK from our app if this is not solved today/tomorrow.

Thanks

Moein-Bam commented 1 year ago

Hey @Moein-Bam , could you update us? We are forced to remove your SDK from our app if this is not solved today/tomorrow. Thanks

@arturonaredo Our team is working on it now. We should be able to release the changes by the end of today.

Moein-Bam commented 1 year ago

Please use the version 0.9.2 and let us know here if it is resolved.

andyrevolve commented 1 year ago

Apple accepted my build. We're good to go. Jst need to update the version number 0.9.2 everywhere. Lower priority of course. Thank you so much for such fast turnaround!!