search

bamcis-io / PrestoClient

A .NET client for Prestodb written targetting .NET Standard 2.0.
MIT License
18 stars 18 forks source link

latest presto-db support, latest dotnet support #12

Closed shmuelf closed 2 years ago

shmuelf commented 2 years ago
  1. since presto-db have presented the new WAITING_FOR_PREREQUISITES header, the client stopped working, so i refreshed StatementStats.cs from the java client
  2. upgraded project files to the latest dotnet release
hakenmt commented 2 years ago

I originally created this project with the intent to have a branch for each version of presto that needed updated support so there wasn't a complicated selection of classes to serde against for changes in the original java code (with main duplicating the latest version). I still think that's the approach I'm going to stick with (but open to hear options). Which version did you test this against?

Also, I haven't been solely targeting the latest .net version to maintain compatibility for older runtimes. For example, there was a time when AWS Lambda functions could only use netstandard1.6. But happy to add .net5 as well.

shmuelf commented 2 years ago

I originally created this project with the intent to have a branch for each version of presto that needed updated support so there wasn't a complicated selection of classes to serde against for changes in the original java code (with main duplicating the latest version). I still think that's the approach I'm going to stick with (but open to hear options). Which version did you test this against?

Also, I haven't been solely targeting the latest .net version to maintain compatibility for older runtimes. For example, there was a time when AWS Lambda functions could only use netstandard1.6. But happy to add .net5 as well.

Thank you for your reply @hakenmt , the server version I ran against was 0.256

hakenmt commented 2 years ago

I've taken these changes and merged them into a new branch 0.256. Thanks for the submission.