search

bamcis-io / PrestoClient

A .NET client for Prestodb written targetting .NET Standard 2.0.
MIT License
18 stars 18 forks source link

Add GitHub CI and modify tests #9

Closed georgevanburgh closed 1 year ago

georgevanburgh commented 3 years ago

Not sure if this is something that is of interest - more than happy for this to not be merged - but thought it would be a good idea to automate running some of the integration tests on PRs. This actions config will pull a presto docker container at the start of the build for the purposes of testing. You're then able to pull the same container locally for developing/testing against.

One of these tests is currently failing (TestGetQuery) - which is think is due to presto changing the shape of the response since the test was written. Happy to take a look at that separately, or mark the test as Explicit, but didn't want to confuse this PR with a test fix.

georgevanburgh commented 3 years ago

You can see an example of tests running over on my fork

hakenmt commented 2 years ago

This is a great idea, and something I think I'll add, just haven't had the time yet to get into the weeds of the solution.

georgevanburgh commented 1 year ago

Superseded by #16