bamlab / flashlight

📱⚡️ Lighthouse for Mobile - audits your app and gives a performance score to your Android apps (native, React Native, Flutter..). Measure performance on CLI, E2E tests, CI...
https://docs.flashlight.dev
MIT License
1.22k stars 29 forks source link

Add tags to web interface #313

Open dr-thca opened 4 months ago

dr-thca commented 4 months ago

Hi, thanks for the great tool.

My current workflow for some ad hoc testing is to run flashlight measure and then run some different tests manually, checking out different code for each test. It would be super nice to add some tags to each test so that they are visible when comparing the results. I guess the simplest workaround is to run flashlight from the cli with some tags in the filename of the report, but it would be nice if you could do something similar in the webinterface.

Edit: I now discovered that the filenames are not shown in the report. That would also be a QOL change so I can see what I'm comparing.

Second edit: Saw now that you can use --resultsTitle

tormoseng commented 2 months ago

A somewhat similiar request is to be able to add tags/labels when running a test with flashlight test. I'm using flashlight test with WebdriverIO/Appium, and to distinguish between test cases it would be nice to better know which test case that causes a performance issue.

Almouro commented 2 months ago

Hi @tormoseng, so for flashlight test we have 2 options:

flashlight test -h

...

  --resultsFilePath <resultsFilePath>      Path where the JSON of results will be written
  --resultsTitle <resultsTitle>            Result title that is displayed at the top of the report

Would that help?

@dr-thca, on your side you'd basically like to have something similar on flashlight measure?