search

bamlab / generator-rn-toolbox

The React Native Generator to bootstrap your apps
MIT License
1.19k stars 119 forks source link

Error: Cannot find module 'universal-analytics' #240

Closed sayem314 closed 4 years ago

sayem314 commented 4 years ago 
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/usr/lib/node_modules/generator-rn-toolbox/analytics.js:1:12)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/usr/lib/node_modules/generator-rn-toolbox/generators/assets/index.js:5:19)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
cristian-milea commented 4 years ago

i installed universal-analytics globally as a temporary fix

npm i -g universal-analytics

sayem314 commented 4 years ago

I did too! But this shouldn’t be the case!

yleflour commented 4 years ago

Hello, sorry for the inconvenience, I just released the fix in 3.13.1 I blindly forgot to include a package.json change in my commit

sayem314 commented 4 years ago

I see you have added this on the new version but next time you should update with yarn and include lock file as well. Just a suggestion!

yleflour commented 4 years ago

I see you have added this on the new version but next time you should update with yarn and include lock file as well. Just a suggestion!

It was already included in the yarn.lock but forgot to commit the package.json. It was a mistake due to the usage of semantic-release which I had to run locally.