search

bamlab / react-native-hide-with-keyboard

Wrap around components to hide them if keyboard is up
MIT License
124 stars 13 forks source link

Add a `ShowWithKeyboard` component which does the inverse #6

Closed davidsharp closed 6 years ago

davidsharp commented 6 years ago

A slight breaking change in that we now export two both HideWithKeyboard and ShowWithKeyboard.

Thrown together in response to #3.

Maybe it's not the most ideal solution, but it gets the ball rolling.

Almouro commented 6 years ago

Hi @davidsharp, sorry for the delay answering, I was on vacation. Thanks for the PR!

To avoid the breaking change, can we do something like:

export { HideWithKeyboard, ShowWithKeyboard };
export default HideWithKeyboard;
davidsharp commented 6 years ago

Fixed 👍

Almouro commented 6 years ago

@davidsharp you wrote export default twice in your fix ;) Also could you add documentation in the README.md for your new feature?

davidsharp commented 6 years ago

D'oh, actually fixed now Also added it to the README

Almouro commented 6 years ago

Great! Thanks for the PR, will publish asap :)

Almouro commented 6 years ago

Closes #3