Fix TriggerView not calling measure callback

bamlab / react-native-image-header-scroll-view

ScrollView with an image in header which becomes a navbar

MIT License

997 stars 99 forks source link

Fix TriggerView not calling measure callback #3

Closed timomeh closed 7 years ago

timomeh commented 7 years ago

view.measure does only work on Android, if view has collapsable: false. See https://github.com/facebook/react-native/issues/3282#issuecomment-253992505

Currently possible with setting collapsable={false} on <TriggerView> ifself, since the view-props get passed through. But should be in the Component itself.

timomeh commented 7 years ago

I just noticed, maybe measure shouldn't happen onScroll. With <TriggerView> mounted, scrolling is really laggy, because onScroll fires like a bajillion times a second, which causes serious frame drops.

Nhacsam commented 7 years ago

Yeah, I noticed the frame drop. Il will try to improve that during the week.

Thanks for your pull request. I will test and merge that tomorrow.