search

bamlab / react-native-image-header-scroll-view

ScrollView with an image in header which becomes a navbar
MIT License
997 stars 99 forks source link

Typescript definitions for this library #47

Closed rodrigoelp closed 5 years ago

rodrigoelp commented 6 years ago

Hi, I was wondering if you guys are interested in type definitions for this library. I would gladly contribute to it as I can see you have some sort of definitions already in the readme file.

ivanguimam commented 5 years ago

I'd be happy with that

Nhacsam commented 5 years ago

@rodrigoelp @ivanguimam I have never done any typescript definition and I didn't use this library in a typescript project yet.

We are moving to typescript in our new project, so will add the definition but I don't know when.

If someone wants to do it and create a pull request, I will be pleased to merge it :-)

rodrigoelp commented 5 years ago

Hi guys, I forgot to push or make this public... I've created a PR with the type def (#58). Hopefully it will be all good.

rodrigoelp commented 5 years ago

@Nhacsam, good to have you onboard with typescript :)

Nhacsam commented 5 years ago

I published it in the 0.10.1 version. Thanks @rodrigoelp