search

bamlab / react-native-image-header-scroll-view

ScrollView with an image in header which becomes a navbar
MIT License
997 stars 99 forks source link

react native 0.60 Please update the following components: TriggeringView #78

Closed georgeMorales closed 3 years ago

georgeMorales commented 4 years ago

With the new versions of react native many methods become obsolete, do you plan to update the library? Thank you!

robertobrogi commented 4 years ago

news about that? thanks

Spoutnik97 commented 4 years ago

@georgeMorales @robertobrogi I planned to update this lib in a few days

sungsong88 commented 4 years ago

+1 for this!

cristoferrao commented 4 years ago

has this issue been resolved i wanted to use it can you give me a alternative to react-native-image-header-scroll-view

sungsong88 commented 4 years ago

@cristoferrao This is resolved ATM by introducing UNSAFE_ to componentWillMount and componentWillReceiveProps for now. If you pull the master with the latest commit, you won't encounter the warning message anymore.

cristoferrao commented 4 years ago

thanks but the warning was removed when i removed the TriggeringView and made hide and that call from HeaderImageScrollView using on scroll start those options

daweido commented 4 years ago

Seems that the version we get when using yarn or npm does not have the TriggeringView changes in it. Is there a way to fix that?

bang9 commented 4 years ago

@Spoutnik97 ping

Spoutnik97 commented 4 years ago

Thanks for the update 🙂 If you have time you can make a pull request to update it, otherwise I try to do it this week

Spoutnik97 commented 4 years ago

Done ✅ I updated the package. Please try v1.0.0 and report errors

daweido commented 3 years ago

@Spoutnik97 Sorry, didn't have time to create pull request.

Thanks! I'll try it out and report any bugs