Closed kueda closed 1 year ago
@kueda
Thank you for your feedback.
For point 1, I have created this PR #330. Thank you for catching it.
For point 2, I will come back to you later with a proper response.
@kueda
For the second point, it's a mistake on my side. Indeed, this parameter was optional before (with default value). The PR above will fix it ⬆️
Thank you again for your feedback.
Fixes have been deployed on version 3.0.1
.
As far as I can tell the example code in the README does not work in 3.0.0 for two reasons:
import ImageResizer from '@bam.tech/react-native-image-resizer';
does not return an object with acreateResizedImage
attribute. Following the example app, you need to doimport { createResizedImage } from '@bam.tech/react-native-image-resizer';
options
argument forcreateResizedImage
does not seem to be optional anymore, so the fact that the README code omits it results in a crash.I was going to just fix the documentation, but I wasn't really sure if these were bugs or intended changes in the functionality.