fix: add missing package name

bamlab / react-native-image-resizer

🗻 Resize local images with React Native

MIT License

1.59k stars 338 forks source link

fix: add missing package name #399

Closed yashb-02 closed 3 months ago

yashb-02 commented 3 months ago

The package attribute was missing from the <manifest> tag in AndroidManifest.xml.

This was causing an error when running the project on android.

versions: react-native: "0.70.6"

itxhamza commented 3 months ago

Please review & merge this PR ASAP. I am trying to deploy my app through CI/CD process and it's giving this error there

taboulot commented 3 months ago

Hi @thehood02,

Thank for the PR. Going to check this today. This PR has introduced the problem you are talking about. It was for handling RN 0.73 & the new gradle version. What surprised me is that I do not have the problem with RN 0.71.8.

@thehood02 & @itxhamza while waiting for me to look, use version 3.0.7 or use patch-package to unblock your situation.

taboulot commented 3 months ago

Indeed I introduced a regression when merging the PR to handle AGP 8.x. Created a new PR that handle all versions here: https://github.com/bamlab/react-native-image-resizer/pull/401

I close this one. Going to deploy 3.0.9 in few minutes.