search

bamlab / react-native-make

A collection of everyday React Native CLI tools
MIT License
762 stars 89 forks source link

set-splash ignores app id #10

Closed rares-lupascu closed 4 years ago

rares-lupascu commented 5 years ago

the build ignores the app id which is something like io.app.client it uses the app segment only

rares-lupascu commented 5 years ago 
{
  errno: -2,
  syscall: 'open',
  code: 'ENOENT',
  path: './android/app/src/main/java/com/app/MainActivity.java'
}

should be

{
  errno: -2,
  syscall: 'open',
  code: 'ENOENT',
  path: './android/app/src/main/java/com/io.app.client/MainActivity.java'
}
rares-lupascu commented 5 years ago

anyone?

peteroid commented 5 years ago

I had the same issue.

The issue is due to https://github.com/bamlab/react-native-make/blob/master/src/modules/setSplashScreen/android/service.ts#L55 where the tool assumes the android source path is same as the package name.

You can hardcode your android source path in ./node_modules/@bam.tech/react-native-make/dist/modules/setSplashScreen/android/service.js and it should work.

yleflour commented 5 years ago

Hello, currently the plugin doesn't use the config argument provided by react-native-cliI will be working on switching to it. But I will have to check that it remains backward compatible (see #6 )

MingyuJeon commented 4 years ago

anyone?

You can make io.app.client folder and behind the folder, copy MainActivity.java file After you generate splash images, remove it. I resolve this issue in this way as a simple temporary solution.

yleflour commented 4 years ago

Should be fixed by #25