search

bamlab / react-native-make

A collection of everyday React Native CLI tools
MIT License
761 stars 86 forks source link

Android - running set-icon removes the application tag #9

Open rares-lupascu opened 4 years ago

rares-lupascu commented 4 years ago

react-native set-icon --platform android --path ./assets/app-icon-android-transparent.png

thes start application tag from AndroidManifest disappears

rares-lupascu commented 4 years ago

anyone?

yleflour commented 4 years ago

Hello, I will be looking into the issue, could you please give me an example the generated manifest versus the expected manifest?

htduy262 commented 4 years ago

I got the same issue. It removes start tag. Also, all ic_launcher_round.png are still set as the default android icon. image

Using "@bam.tech/react-native-make": "^3.0.0"

Any suggestions, please?

thinklinux commented 4 years ago

@rares-lupascu the problem with me was that my AndroidManifest.xml file wasn't formatted in a way that react-native set-icon can handle. Every property of the tag should be on a new line like that for example:

  <application
    android:name=".MainApplication"
    android:label="@string/app_name"
    android:icon="@mipmap/ic_launcher"
    android:launchMode="singleTop"
    android:allowBackup="false"
    android:theme="@style/AppTheme">

Otherwise the tag gets removed for some reason.