search

bamlab / react-tv-space-navigation

A React Native module to handle spatial navigation for a TV application in a 100% cross-platform way
https://bamlab.github.io/react-tv-space-navigation/
MIT License
178 stars 15 forks source link

Calculate scaled factors for pixel with react-native-pixel-perfect #126

Open giolaq opened 1 month ago

giolaq commented 1 month ago

I've found the using react-native-pixel-perfect makes it easier to adapt the scaling factor across different screens.

The library is considering width and height that can be defined by the developers or runtime.

Tested on Android TV, Fire TV, tvOS and web.

Check if it makes sense! Thank you!

pierpo commented 1 month ago

It makes sense but I'm not sure there is that much added value: the calculation is very simple and is present only once in the codebase, in a separate place 😁 I'm not sure we need to add a dependency for that!

Maybe there are additional features that I missed? Would be nice to define it at runtime but I'm not sure components would re-render, since this is computed at root level.

giolaq commented 1 month ago

Agree that adding a dependency for this is an overkill. I found that testing on Fire TV/Android TV emulator/Web was giving me some issue with the UI not following the same proportions. I have tested with the react-native-pixel-perfect and all was fixed. I think their formula maybe is more completed as taking as variable also the height. Let me get back with more testing and some screenshots 🙏 probably we can just modify the calculation