search

bamthomas / aioimaplib

Python asyncio IMAP4rev1 client library
GNU General Public License v3.0
135 stars 58 forks source link

quote password properly in IMAP dialog #29

Closed FelixSchwarz closed 6 years ago

FelixSchwarz commented 7 years ago

The actual quoting code was copied from https://github.com/mjs/imapclient (imapclient/imapclient.py) and used under the 3-clause BSD license.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 95.503% when pulling 53437d86975e6b1367aeb3be3bc2a2f3902beb05 on FelixSchwarz:master into 9e655ba4b7aec4a60db8f6a603bcc9aac59c75d1 on bamthomas:master.

bamthomas commented 7 years ago

Thank you for the pull request.

I'd like to add some unit tests on the _quote method (to document and test what it does). If you cannot add the tests, I'll do it soon

FelixSchwarz commented 7 years ago

Probably I won't have too much time in the next days but you might want to have a look at the imapclient code from which I copied the function.

aliceh75 commented 6 years ago

Hello,

I've created a new PR (which builds on this one) and includes the unit tests for the quote function.