search

banach-space / clang-tutor

A collection of out-of-tree Clang plugins for teaching and learning
The Unlicense
659 stars 62 forks source link

LLVM 13 support #21

Closed SamuelMarks closed 2 years ago

SamuelMarks commented 2 years ago

Closes #20

WiP I guess

banach-space commented 2 years ago

Many thanks for submitting this! I've left a few suggestions inline. We will also have to update the CI files. Would you be able to do that, pls?

-Andrzej

SamuelMarks commented 2 years ago

Done. Where are the inline suggestions?

SamuelMarks commented 2 years ago
  1. .editorconfig is an IDE/editor independent format. I noticed your two spaces causing problems with my IDE by default.
  2. I can update the commit message on squash, but as you say you can squash from your GitHub UI interface (which I'm fine with)
  3. Happy to help :)
banach-space commented 2 years ago
  1. Would .clang-format work for you as well? That would be my preferred format.
SamuelMarks commented 2 years ago

@banach-space Sure I don't care, as long as it's a format that IDEs and editors recognise (and it is).

banach-space commented 2 years ago

LGTM, let's merge this! Shall I squash this with the web UI? Or do you prefer to do it yourself?

SamuelMarks commented 2 years ago

Great, merge away

(squash in web UI is fine)