delete legacy PM example and usage

banach-space / llvm-tutor

A collection of out-of-tree LLVM passes for teaching and learning

MIT License

2.95k stars 393 forks source link

delete legacy PM example and usage #105

Closed FinleyTang closed 11 months ago

FinleyTang commented 11 months ago

I previously submitted a pull request, and after discussing with you, we reached an agreement to remove the legacy usage and example. However, multiple commits from me resulted in a confusing submission. I have made the necessary changes and resubmitted the pull request.

FinleyTang commented 11 months ago

I found some check errors, and I'm not sure if it's related to me.

I just deleted the legacy PM-related content from the hello world code, and my local tests (in the Ubuntu 22.04 environment) were successful.

This is my first time submitting a PR. I apologize if there are any issues causing trouble. @banach-space

banach-space commented 11 months ago

No apology required - your contribution is benefiting us all and is greatly appreciated 🙏🏻 . The pre-commit CI for llvm-tutor looks good. The failing jobs are due to the recent update to LLVM 17 (i.e. unrelated to this change).

Thanks for seeing this through and responding so promptly!