search

banach-space / llvm-tutor

A collection of out-of-tree LLVM passes for teaching and learning
MIT License
2.95k stars 393 forks source link

[CMake] Display header files in Xcode #88

Closed WowbaggersLiquidLunch closed 1 year ago

WowbaggersLiquidLunch commented 1 year ago

Normally Xcode projects generated by CMake contain only the source files for each target. This change adds the header files too, making it easier to use Xcode.

WowbaggersLiquidLunch commented 1 year ago

The 2 build failures seem unrelated to this PR.

banach-space commented 1 year ago

Hi @WowbaggersLiquidLunch , thank you for visiting and for preparing this PR!

The 2 build failures seem unrelated to this PR.

Indeed, these are unrelated. However, I am hesitant to merge this for a few of reasons:

  1. IIUC, this will only benefit XCode users. For everyone else (including me), this is just noise.
  2. This change is not required for llvm-tutor to work.
  3. The goal of llvm-tutor is to make everything as simple as possible. This change adds extra complexity in CMake, which most people find particularly tricky.

I really appreciate this PR. Sadly, it doesn't align with what I had in mind when starting this project. Namely, simplicity first. Perhaps you could add a section in README.md instead?

All the best, Andrzej