banacorn / agda-mode-vscode

agda-mode on VS Code
https://marketplace.visualstudio.com/items?itemName=banacorn.agda-mode
MIT License
169 stars 39 forks source link

[ fix ] Update language-server-mule to 0.2.4 (Fixes LSP) #126

Closed jul1u5 closed 9 months ago

jul1u5 commented 1 year ago

Closes #116 #122. And possibly fixes #86.

Before merging this, it's probably better to get the upstream fixed https://github.com/banacorn/language-server-mule/pull/1 and then update the dependency ref to "v0.2.4" instead of pinning it to a specific commit (like how it is now).

MathiasSven commented 1 year ago

I attempted to build this extension with the commit and for me #122 persists. Worth noting that my als is also not the default one but instead this but I don't think that is related. Did you manage to get this extension working within NixOS?

jul1u5 commented 1 year ago

Hi @MathiasSven, I added a flake in a separate branch https://github.com/jul1u5/agda-mode-vscode/commit/96f20bf8317ea9af98ed71422534d953482517e4 (I've also patched als to build Agda 2.6.2.2). If you have flakes enabled, you can try to clone it. Let me know if this works for you.

IIRC, I got the extension building on NixOS by enabling nix-ld:

{
  programs.nix-ld.enable = true;
}

Then npm install && npm run build should just work inside the nix develop shell.

(I tested the extension through VS Code's Run and Debug menu)

jul1u5 commented 1 year ago

@banacorn friendly ping :) Have you looked at this PR (and also https://github.com/banacorn/language-server-mule/pull/1) yet?

MathiasSven commented 1 year ago

Yes! That worked like a charm! For docs, I ended up doing:

nix develop --impure
nix-shell -p vsce
npm install && npm run build
vsce package

Installed the vsix and just used that version of the nixpkgs from the flake.lock on my shell.nix instead of <nixpkgs> plus adding an override for the patch you provided. I use Nix Environment Selector on my vscode so I am sticking with shell.nix for now, haven't looked too much into flakes.

jul1u5 commented 1 year ago

Nice, glad it worked!

banacorn commented 9 months ago

Thank you for this PR! Sorry I didn't have the time and energy to look at this then, but now I'm back!