search

banacorn / agda-mode

agda-mode on Atom
https://atom.io/packages/agda-mode
MIT License
58 stars 14 forks source link

Spaces break the executable path in Windows #75

Closed dylanbraithwaite closed 5 years ago

dylanbraithwaite commented 5 years ago

It seems like spaces in the executable path aren't being properly escaped in Windows. In particular I couldn't find a way to make C:\Program Files\Haskell\bin\agda.exe work as a path. The plugin reports

Found something at "C:\Program Files\Haskell\bin\agda.exe" but it doesn't seem quite right:
Command failed: C:/Program Files/Haskell/bin/agda.exe
'C:/Program' is not recognized as an internal or external command, operable program or batch file.
banacorn commented 5 years ago

Thanks for reporting this!

Invisible-Rabbit-Hunter commented 5 years ago

Fixed this by adding quotes around the path, i.e "C:\Program Files\Haskell\bin\agda.exe" instead of C:\Program Files\Haskell\bin\agda.exe.

dylanbraithwaite commented 5 years ago

I'm almost certain I had tried adding quotation marks without any change before opening this issue. I eventually gave up trying to install the plugin after running into a similar issue to #68 (using a path without spaces for agda) but I'll reinstall tomorrow and see if quoting the path makes any difference now. Thanks!

banacorn commented 5 years ago

I was able to reproduce this issue, and the workaround provided by @Supernerd11 (adding quotes around the path) also worked as well.