banacorn / language-agda

Agda language support for the Atom editor
https://atom.io/packages/language-agda
MIT License
13 stars 5 forks source link

Many keywords do not highlight as such #5

Closed exists-forall closed 6 years ago

exists-forall commented 7 years ago

Most importantly, the syntax highlighting grammar in this package does not identify let, in, or with as keywords, making it more difficult to read code that uses these constructs.

More generally, not all keywords from this list of keywords seem to highlight:

 =
 |
 ->
 :
 ?
 \
 →
 ∀
 λ
 abstract
 constructor
 data
 field
 forall
 hiding
 import
 in
 infix
 infixl
 infixr
 let
 module
 mutual
 open
 postulate
 primitive
 Prop
 private
 public
 quoteGoal
 quoteTerm
 quote
 record
 renaming
 rewrite
 Set[0-9]*
 syntax
 unquote
 using
 where
 with

Highlighting may be inappropriate for the non-alphanumeric "keywords" like and

banacorn commented 7 years ago

Thanks for listing the keywords out! The syntax highlighting is really lacking, but I have little knowledge about how Atom's language grammar works.

I guess I can only leave this issue open for the moment :(

banacorn commented 6 years ago

please try out the new parser! :)