search

banago / PHPloy

PHPloy - Incremental Git (S)FTP deployment tool that supports multiple servers, submodules and rollbacks.
http://wplancer.com/phploy/
1.42k stars 197 forks source link

Incompatibility with League/Flysystem #383

Closed a3gz closed 3 years ago

a3gz commented 3 years ago

Hello, I noticed today that there's an incompatibility with PHPloy and the latest version of League/Flysystem.

The following are lines 5 to 7 of src/Connection.php

5 use League\Flysystem\Adapter\Ftp as FtpAdapter;
6 use League\Flysystem\Filesystem;
7 use League\Flysystem\Sftp\SftpAdapter as SftpAdapter;

PHPloy version 4.9.1 will require Flysystem 2.0.0 where the files referenced on lines 5 and 7 don't exist anymore. They have at least changed locations. I say "at least" because I don't know if they have also changed behavior. In any case, my pipleline started to crash today due to this.

I believe that the issue may be the change in requiring Flysystem ^1.0 to >=1.0.0. If I'm not mistaken, by requiring >=1.0.0 we also need to specify the higher limit as in >=1.0.0 <2.0 to prevent installing versions that carry breaking changes.

I could solve the issue by specifically using PHPloy v 4.8.5.

a3gz commented 3 years ago

I'm so dumb! There was already a pull request pending to fix this.