Fixes #10 HttpsURLConnection does not support PATCH

banana-j / bananaj

Java API wrapper for MailChimp API 3.0

MIT License

38 stars 33 forks source link

Fixes #10 HttpsURLConnection does not support PATCH #15

Closed gscriver closed 6 years ago

gscriver commented 6 years ago

This pull request replaces Connection.java with a variant that uses Apache HttpClient for the transport layer. This fixes the html PATCH verb not supported and addresses a PUT verb issue. Mailchimp API update operations will work with this fix.

You can use this until the Unirest #12 work is complete.

alexanderwe commented 6 years ago

@gscriver Thanks a lot for implementing the Apache HTTP Client. Your pull request seems good so far, so I will merge it. I really appreciate your work here ! I also think I need to set up CI and tests in some way, as they are missing right now, but that's another issue.