bananajuicellc / first.bananajuice.tech

A selection game to help gamers pick who goes first.
https://whogoes1st.com
Mozilla Public License 2.0
1 stars 3 forks source link

Redirect `/` to most appropriate language, not just English. #46

Closed tswast closed 8 years ago

tswast commented 8 years ago

We used to do this server-side, but with https://github.com/whogoesfirst/who-goes-first/pull/44 we are now doing it with an HTML meta refresh.

This loses the behavior of looking at the Accept-Language headers to choose the most appropriate language. We'll have to see if we can reproduce that behavior using JavaScript. Sounds like we might need some server-side code to send back a JSONP of these headers, unless navigator.languages gives us what we want?

tswast commented 8 years ago

We already save a "preferredLanguage" in the "deck" in local storage. Why don't we use that?

tswast commented 8 years ago

This was fixed in https://github.com/whogoesfirst/who-goes-first/pull/51.