bananaml / banana-python-sdk

16 stars 11 forks source link

Hotchange/snakecase #17

Closed erik-dunteman closed 10 months ago

erik-dunteman commented 10 months ago

What is this?

Quick pre-launch breaking change on the method naming, to be snake cased

Why?

Ideomatic

How did you test it works without regressions?

If this is a new feature what may a critical error look like?

Things to consider to not repeat mistakes we've learned from many times

[ ] If critical errors fire do we ping team in some obvious way (e.g., slack)?
[ ] Are there debug logs + a way to see these logs if we need to debug?
[ ] Is this documented enough a dev could work on this code without getting stuck or having to ping you?

nik-418 commented 10 months ago

lgtm