Closed RevCBH closed 1 year ago
+1 to this. The specified version of urllib
is below the minimum required for sentry-sdk
+1 to this, I am trying to integrete sentry with banana-dev, but banana-dev is pinned to urllib3==1.26.7, whereas sentry-srk is looking for urllib3 >= 1.26.11
Hey! I'll take this on, will test with most recent requests version and peg the version as a range between the two. Will report back.
requests has a SemVer policy thankfully so we can follow that https://requests.readthedocs.io/en/latest/community/release-process/
will make urlLib min 1.26.11 and let requests dictate exactly which
I've loosened requirements to requests>=2.26.0,<3.0.0
which allows for urllib3 version 1.26.13
, and have verified that the latest sentry-sdk==1.12.1
successfully installs withurllib3>=1.26.11
requirement met.
Changes can be viewed here https://github.com/bananaml/banana-python-sdk/pull/6
I'll be pushing this momentarily as banana-dev==4.0.1
to pypi, so feel free to upgrade your install with pip3 install banana-dev==4.0.1
Confirming this is deployed as version 4.0.1 :)
Same tests pass on live version.
@RevCBH @tonyf @lingster thanks for raising the issue and the patience on the fix here. Cheers! Let me know if any other issues arise.
I'm running into a conflict with
banana-dev
depending onrequests==2.26.0
. I needrequests>=2.27.0
and was wondering if the was a reason for such a narrow constraint.