search

bananaml / banana-python-sdk

16 stars 11 forks source link

added BANANA_SERVER env var for pointing at direct server endpoint #7

Closed erik-dunteman closed 1 year ago

erik-dunteman commented 1 year ago

What is this?

Adds BANANA_SERVER env var, which points to local dev servers or remote urls and calls that directly with a single POST request, rather than routing through our middleware.

Why?

  1. to allow for testing locally with the SDK
  2. to prep for an upcoming bananav2 infra change where you call a URL directly

How did you test to ensure no regressions?

Ran it with and without this BANANA_SERVER on a prod model and local hosted model, works

If this is a new feature what is one way you can make this break?

A user could theoretically already have a BANANA_SERVER env var in prod for whatever reason, so we're at risk of that causing issues.

erik-dunteman commented 1 year ago

Tested, version bump to 4.0.2 going live then will merge

erik-dunteman commented 1 year ago

4.0.2 live