bananaml / potassium

An HTTP serving framework by Banana
Apache License 2.0
97 stars 9 forks source link

Add pyright + __status__ endpoint #29

Closed Peddle closed 1 year ago

Peddle commented 1 year ago

What is this?

Adds pyright to cicd + updates existing code to pass pyright. Also adds status endpoint

Why?

improved code quality / readability / reduces bugs in future.

status endpoint is a handy healthcheck and can be extended with GPU status in future

How did you test it works without regressions?

Follow on PR to add unit testing + integration tests (should block master release on this). For now simple manual tests seem to pass

If this is a new feature what may a critical error look like?

Things to consider to not repeat mistakes we've learned from many times

ErikKaum commented 1 year ago

All in all really legit 🔥