bananaml / potassium

An HTTP serving framework by Banana
Apache License 2.0
97 stars 9 forks source link

Warmup calls #36

Closed nik-418 closed 1 year ago

nik-418 commented 1 year ago

What is this?

Exposes a /_k/warmup endpoint.

Fixes BAN-392

See also: https://github.com/bananaml/banana-python-sdk/pull/15

See also: https://github.com/bananaml/banana-node-sdk/pull/10

Why?

Some use cases benefit from finer control over the timing of cold/warm dynamics.

How did you test it works without regressions?

image
ErikKaum commented 1 year ago

General question, do we want to merge this directly into main and push a new version? Or just have it in staging?

nik-418 commented 1 year ago

General question, do we want to merge this directly into main and push a new version? Or just have it in staging?

Following previous convention and instructions from @erik-dunteman , I personally don't mind.