search

bananenfisch / RecentItems

Recent Items - an extension for gnome-shell
GNU General Public License v3.0
25 stars 11 forks source link

Gnome 46 Not working #24

Closed Sidethorn closed 5 months ago

Sidethorn commented 7 months ago

Not working under gnome 46 and can you please add option to delete not needed items straight from the extension, like it did https://extensions.gnome.org/extension/977/recent-items. Thanks

molitona commented 6 months ago

@Sidethorn did y found a solution ? even editing metadata.json by replacing it with gnome 46 didn't work for me!

molitona commented 6 months ago

@bananenfisch

bananenfisch commented 6 months ago

I run debian sid (unstable) and debian stable systems - debian sid is still on gnome 44.9. They are busy to do the big t64 transition (https://wiki.debian.org/ReleaseGoals/64bit-time).

I do not have enough resources to setup a VM with the latest gnome just 2 weeks after every release just for testing and fixing. So, just wait: when gnome 46 arrives debian sid, i will fix it.

Or: just help me ;-) Any error messages would be great!

molitona commented 6 months ago

ok, i'm on arch. tell me what to do and i'll reply to u

bananenfisch commented 6 months ago

What's the output of journalctl | grep -i recentitems Maybe the fix is simple.

molitona commented 6 months ago

in gnome extension app i get this error shown in a popup

TypeError: this.add_actor is not a function

s

the out of the cmd is as below

_launchFile@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:161:11
                                           _sync/<@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:122:18
                                           _launchFile@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:161:11
                                           _sync/<@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:122:18
Apr 04 17:45:50 Unknown gnome-shell[11498]: Extension RecentItems@bananenfisch.net: TypeError: this.add_actor is not a function
                                              RecentItems@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:68:12
                                              enable@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:28:16
                                            The offending signal was destroy on Gjs_RecentItems_bananenfisch_net_extension_RecentItems 0x64e012ba0c60.
Apr 04 18:00:26 Unknown gnome-shell[17852]: Extension RecentItems@bananenfisch.net: TypeError: this.add_actor is not a function
                                              RecentItems@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:68:12
                                              enable@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:28:16
                                            The offending signal was destroy on Gjs_RecentItems_bananenfisch_net_extension_RecentItems 0x5b1ca8352410.
Apr 04 18:01:32 Unknown gnome-shell[19813]: Extension RecentItems@bananenfisch.net: TypeError: this.add_actor is not a function
                                              RecentItems@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:68:12
                                              enable@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:28:16
                                            The offending signal was destroy on Gjs_RecentItems_bananenfisch_net_extension_RecentItems 0x61e22c170900.
Apr 04 18:10:31 Unknown gnome-shell[24036]: Extension RecentItems@bananenfisch.net: TypeError: this.add_actor is not a function
                                              RecentItems@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:68:12
                                              enable@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:28:16
                                            The offending signal was destroy on Gjs_RecentItems_bananenfisch_net_extension_RecentItems 0x59a149955900.
Apr 04 18:11:50 Unknown gnome-shell[26047]: Extension RecentItems@bananenfisch.net: TypeError: this.add_actor is not a function
                                              RecentItems@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:68:12
                                              enable@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:28:16
                                            The offending signal was destroy on Gjs_RecentItems_bananenfisch_net_extension_RecentItems 0x611d4462ed40.
Apr 04 18:36:10 Unknown gnome-shell[98636]: Extension RecentItems@bananenfisch.net: TypeError: this.add_actor is not a function
                                              RecentItems@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:68:12
                                              enable@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:28:16
                                            The offending signal was destroy on Gjs_RecentItems_bananenfisch_net_extension_RecentItems 0x60e5d53cb050.
Apr 04 18:40:34 Unknown gnome-shell[101226]: Extension RecentItems@bananenfisch.net: TypeError: this.add_actor is not a function
                                               RecentItems@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:68:12
                                               enable@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:28:16
Apr 05 18:05:18 Unknown gnome-shell[3556]: Extension RecentItems@bananenfisch.net: TypeError: this.add_actor is not a function
                                             RecentItems@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:68:12
                                             enable@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:28:16
Apr 05 18:15:03 Unknown gnome-shell[9192]: Extension RecentItems@bananenfisch.net: TypeError: this.add_actor is not a function
                                             RecentItems@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:68:12
                                             enable@file:///home/user/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net/extension.js:28:16
molitona commented 6 months ago

as to per https://github.com/bmwiedemann/openSUSE/blob/13c1179cab4f21925e453e039e04d9174e286d7a/packages/h/hamster-time-tracker/0174-Fix-compatibility-issues-with-Gnome-shell-46.patch#L4

replaced this.add_actor by this.add_child on line 68 and now got other error -> this.box.add is not a function

molitona commented 6 months ago

i fixed it @bananenfisch !!

molitona commented 6 months ago

i'll create a PR

molitona commented 6 months ago

I noticed that i made a PR with the modified version of @BlankParticle

gnome 46 patch is just replacing (add_actor) and (add) methods by (add_child)

for a reason i dunno it didn't work with @BlankParticle and don't have time to debug

so i put the zip of the old version which works perfect on gnome 46 with the applied patch

RecentItems@bananenfisch.net.zip

bananenfisch commented 6 months ago

That's great! Thx for fixing :) I have the changes in the latest release: https://github.com/bananenfisch/RecentItems/releases

If this version works on gnome 46, i'll upload to extensions. Any feedback welcome...

(I hope, debian will update gnome soon for maintaining without installing VMs in the future ;))

BlankParticle commented 6 months ago

Hey, sorry I was not able to work on this, I kinda suspected this. I am currently not using gnome, and setting up a gnome VM to test the extension was pain. Most extensions worked with just the metadata, but I had to change this function in my extensions too.

Glad you got it fixed

molitona commented 6 months ago

That's great! Thx for fixing :) I have the changes in the latest release: https://github.com/bananenfisch/RecentItems/releases

If this version works on gnome 46, i'll upload to extensions. Any feedback welcome...

(I hope, debian will update gnome soon for maintaining without installing VMs in the future ;))

thank u, yeah it works perfectly!

molitona commented 6 months ago

Hey, sorry I was not able to work on this, I kinda suspected this. I am currently not using gnome, and setting up a gnome VM to test the extension was pain. Most extensions worked with just the metadata, but I had to change this function in my extensions too.

Glad you got it fixed

thanks which DE u currently use?

Sidethorn commented 6 months ago

Thanks everybody it works perfectly.

molitona commented 6 months ago

Thanks everybody it works perfectly.

very happy to help

InklingGirl commented 6 months ago

Hey, if the fix is working, when will it be pushed to https://extensions.gnome.org/extension/72/recent-items/ @bananenfisch? The latest LTS release of Ubuntu will be coming out w/ GNOME 46 this month, so it would be great to have in time for the launch.

Sidethorn commented 5 months ago

will this working release ever make it into the gnome shell extension page?

molitona commented 5 months ago

@InklingGirl @Sidethorn replace extensions.js in ~/.local/share/gnome-shell/extensions/RecentItems@bananenfisch.net with the one i mentioned then logout+login

bananenfisch commented 5 months ago

finally... should be on extensions.gnome.org after review.

InklingGirl commented 5 months ago

not yet it ain't, must be pending still