Kbok fixes - Githubissues

bananu7 / Hate

A small 2D game framework in Haskell, for Haskell

MIT License

26 stars 2 forks source link

Kbok fixes #29

Closed ghost closed 9 years ago

ghost commented 9 years ago

FYI, here are the changes I had to make to make Hate work on my machine:

GLFW-b 1.4.7 and 1.4.7.1 wouldn't build
Greater versions of OpenGL would cause a silent exit with code 1

ghost commented 9 years ago

I'm actually not sure if this should make the tree -- I thought I'd leave it here in case we needed to point people to workarounds. The build fail should be fixed instead, but I'm not sure if the issue comes from me. Regarding the GL version, I agree this shouldn't be hardcoded.

I can make a PR with a single commit, thought, if you'd like.

bananu7 commented 9 years ago

I've already introduced the upper bound in the newest version. Until the issue with GLFW-b is sorted out, I think it's a good choice.

bananu7 commented 9 years ago

After giving it some thought, I'm closing this PR w/o merge. The GLFW-b cap is in master, and the other problems are being solved in a proper manner: #12 and #27/#15. Please leave any additional comments there.