bancaditalia / black-it

Black-box abm calibration kit by the Bank of Italy
https://bancaditalia.github.io/black-it/
GNU Affero General Public License v3.0
42 stars 2 forks source link

Enable CI on `windows-latest` #48

Closed marcofavoritobi closed 1 year ago

marcofavoritobi commented 1 year ago

Proposed changes

This PR makes the test CI workflow to run over windows-latest.

Fixes

n/a

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

Checklist

n/a

codecov-commenter commented 1 year ago

Codecov Report

Merging #48 (6a3b098) into main (4624af4) will increase coverage by 0.06%. The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/bancaditalia/black-it/pull/48/graphs/tree.svg?width=650&height=150&src=pr&token=FwbdPgBFTD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)](https://codecov.io/gh/bancaditalia/black-it/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #48 +/- ## ========================================== + Coverage 96.79% 96.86% +0.06% ========================================== Files 31 31 Lines 1499 1499 ========================================== + Hits 1451 1452 +1 + Misses 48 47 -1 ``` | [Impacted Files](https://codecov.io/gh/bancaditalia/black-it/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [black\_it/loss\_functions/gsl\_div.py](https://codecov.io/gh/bancaditalia/black-it/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YmxhY2tfaXQvbG9zc19mdW5jdGlvbnMvZ3NsX2Rpdi5weQ==) | `100.00% <ø> (ø)` | | | [black\_it/samplers/xgboost.py](https://codecov.io/gh/bancaditalia/black-it/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YmxhY2tfaXQvc2FtcGxlcnMveGdib29zdC5weQ==) | `100.00% <100.00%> (+1.78%)` | :arrow_up: |
marcofavoritobi commented 1 year ago

Tests failing on Windows: https://github.com/bancaditalia/black-it/actions/runs/4451921576/jobs/7819104632?pr=48#step:6:3367

FAILED tests/test_calibrator.py::TestCalibrate::test_calibrator_calibrate[2]
FAILED tests/test_calibrator.py::TestCalibrate::test_calibrator_calibrate[1]
FAILED tests/test_examples/test_docker_sir.py::TestDockerSirMainExample::test_run
FAILED black_it/loss_functions/gsl_div.py::black_it.loss_functions.gsl_div.GslDivLoss.discretize
FAILED tests/test_samplers/test_xgboost.py::test_xgboost_2d - assert False
marcofavoritobi commented 1 year ago

Thanks @AldoGl for ce29fdf and f4655d5!