bancaditalia / black-it

Black-box abm calibration kit by the Bank of Italy
https://bancaditalia.github.io/black-it/
GNU Affero General Public License v3.0
42 stars 2 forks source link

build: remove 'ipykernel' dependency #75

Closed marcofavoritobi closed 6 months ago

marcofavoritobi commented 11 months ago

Proposed changes

The dependency ipykernel is not used directly from any module in black-it, hence it should not be declared as main dependency of the package. This PR removes it from the section tool.poetry.dependencies in pyproject.toml, and recomputes poetry.lock by using poetry lock --no-update.

Potentially breaking change if packages dependent of black-it use ipykernel directly (unlikely).

codecov-commenter commented 11 months ago

Codecov Report

Merging #75 (5ea9fdd) into main (065785f) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/bancaditalia/black-it/pull/75/graphs/tree.svg?width=650&height=150&src=pr&token=FwbdPgBFTD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)](https://app.codecov.io/gh/bancaditalia/black-it/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #75 +/- ## ======================================= Coverage 89.22% 89.22% ======================================= Files 42 42 Lines 1782 1782 ======================================= Hits 1590 1590 Misses 192 192 ```
muxator commented 11 months ago

We should see if there are any examples/documentation that need to be updated

marcofavoritobi commented 11 months ago

We should see if there are any examples/documentation that need to be updated

I don't think so, for the following reasons:

muxator commented 6 months ago

Closing in favor of #78, which includes this one.