Closed marcofavoritobi closed 6 months ago
Merging #75 (5ea9fdd) into main (065785f) will not change coverage. The diff coverage is
n/a
.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
We should see if there are any examples/documentation that need to be updated
We should see if there are any examples/documentation that need to be updated
I don't think so, for the following reasons:
ipykernel
is never used directly, neither in docs nor in examples.ipykernel
is included in them, due to e.g. nbmake
, jupyter
etc.ipykernel
is needed by ipywidgets
, which atm is a main dependency; therefore, ipykernel
is always installed, hence nothing changed from the library perspective.Closing in favor of #78, which includes this one.
Proposed changes
The dependency
ipykernel
is not used directly from any module inblack-it
, hence it should not be declared as main dependency of the package. This PR removes it from the sectiontool.poetry.dependencies
inpyproject.toml
, and recomputespoetry.lock
by usingpoetry lock --no-update
.Potentially breaking change if packages dependent of
black-it
useipykernel
directly (unlikely).