search

bancika / diy-layout-creator

multi platform circuit layout and schematic drawing tool
http://diy-fever.com
GNU General Public License v3.0
854 stars 99 forks source link

"Analyze Guitar Diagrams" not working as expected, Problem 2 (v4.37) #794

Open PenBach opened 8 months ago

PenBach commented 8 months ago

Analyze Guitar Diagrams often gives TreeException and does not give any Analysis results.

I often get the error MessageBox "org.diylc.netlist.TreeException: Could not find anything connected to a jack tip terminal"

Im guessing it may be caused when for example a lever switch does not have an "Output" for all of its positions, even though that is a valid setup.

Using the "DP3T (Standard 5-Position Strat)", If we take the row of terminals "Com 1 3 5" and wire two pickups 1 - PickupHB 3 - PickupSCM 5 - No connection Com - Output

Gives the error/exception.

This is from the log (v4.37) Caused by: org.diylc.netlist.TreeException: Could not find anything connected to a jack tip terminal. at org.diylc.netlist.GuitarDiagramAnalyzer.constructTree(GuitarDiagramAnalyzer.java:364) at org.diylc.netlist.GuitarDiagramAnalyzer.summarize(GuitarDiagramAnalyzer.java:101) at org.diylc.netlist.NetlistAnalyzer.summarize(Unknown Source) at org.diylc.swing.ActionFactory$SummarizeNetlistAction$1.doInBackground(Unknown Source) at org.diylc.swing.ActionFactory$SummarizeNetlistAction$1.doInBackground(Unknown Source) at org.diylc.swing.gui.MainFrame$6.doInBackground(Unknown Source) at javax.swing.SwingWorker$1.call(Unknown Source) at java.util.concurrent.FutureTask.run(Unknown Source) at javax.swing.SwingWorker.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source)

PenBach commented 8 months ago

I've attached a diagram as requested. I had to tag on ".txt" for GitHub to accept it. Just remove the extra ".txt" extension.

Test_Strat5way3PDT_794.diy.txt

DeltaPotential commented 6 months ago

I finished mocking up the wiring of a new, to me, guitar and I get the same error; log [below] is slightly different. I also tried to use the analyze feature on @PenBach's file and I'm returned the same error.

OS: MacOS v12.6.9 diylc v4.37.0

02:06:47,188 INFO [SwingWorker-pool-1-thread-4] ConfigurationManager - Saving configuration 02:06:51,885 ERROR [AWT-EventQueue-0] MainFrame - Background task execution failed java.util.concurrent.ExecutionException: org.diylc.netlist.TreeException: Could not find anything connected to a jack tip terminal. at java.util.concurrent.FutureTask.report(FutureTask.java:122) at java.util.concurrent.FutureTask.get(FutureTask.java:192) at javax.swing.SwingWorker.get(SwingWorker.java:602) at org.diylc.swing.gui.MainFrame$6.done(Unknown Source) at javax.swing.SwingWorker$5.run(SwingWorker.java:737) at javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.run(SwingWorker.java:832) at sun.swing.AccumulativeRunnable.run(AccumulativeRunnable.java:112) at javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.actionPerformed(SwingWorker.java:842) at javax.swing.Timer.fireActionPerformed(Timer.java:313) at javax.swing.Timer$DoPostEvent.run(Timer.java:245) at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311) at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758) at java.awt.EventQueue.access$500(EventQueue.java:97) at java.awt.EventQueue$3.run(EventQueue.java:709) at java.awt.EventQueue$3.run(EventQueue.java:703) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74) at java.awt.EventQueue.dispatchEvent(EventQueue.java:728) at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93) at java.awt.EventDispatchThread.run(EventDispatchThread.java:82) Caused by: org.diylc.netlist.TreeException: Could not find anything connected to a jack tip terminal. at org.diylc.netlist.GuitarDiagramAnalyzer.constructTree(GuitarDiagramAnalyzer.java:364) at org.diylc.netlist.GuitarDiagramAnalyzer.summarize(GuitarDiagramAnalyzer.java:101) at org.diylc.netlist.NetlistAnalyzer.summarize(Unknown Source) at org.diylc.swing.ActionFactory$SummarizeNetlistAction$1.doInBackground(Unknown Source) at org.diylc.swing.ActionFactory$SummarizeNetlistAction$1.doInBackground(Unknown Source) at org.diylc.swing.gui.MainFrame$6.doInBackground(Unknown Source) at javax.swing.SwingWorker$1.call(SwingWorker.java:295) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at javax.swing.SwingWorker.run(SwingWorker.java:334) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:750)

Edit: The switch I'm using in my diagram is the DP3T (Import 5-Position Strat)

bancika commented 6 months ago

please upload your DIY file so I can replicate the issue locally.

On Mon, Oct 23, 2023 at 2:18 AM DeltaPotential @.***> wrote:

I finished mocking up the wiring of a new, to me, guitar and I get the same error; log [below] is slightly different. I also tried to use the analyze feature on @PenBach https://github.com/PenBach's file and I'm returned the same error.

OS: MacOS v12.6.9 diylc v4.37.0

02:06:47,188 INFO [SwingWorker-pool-1-thread-4] ConfigurationManager - Saving configuration 02:06:51,885 ERROR [AWT-EventQueue-0] MainFrame - Background task execution failed java.util.concurrent.ExecutionException: org.diylc.netlist.TreeException: Could not find anything connected to a jack tip terminal. at java.util.concurrent.FutureTask.report(FutureTask.java:122) at java.util.concurrent.FutureTask.get(FutureTask.java:192) at javax.swing.SwingWorker.get(SwingWorker.java:602) at org.diylc.swing.gui.MainFrame$6.done(Unknown Source) at javax.swing.SwingWorker$5.run(SwingWorker.java:737) at javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.run(SwingWorker.java:832) at sun.swing.AccumulativeRunnable.run(AccumulativeRunnable.java:112) at javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.actionPerformed(SwingWorker.java:842) at javax.swing.Timer.fireActionPerformed(Timer.java:313) at javax.swing.Timer$DoPostEvent.run(Timer.java:245) at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311) at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758) at java.awt.EventQueue.access$500(EventQueue.java:97) at java.awt.EventQueue$3.run(EventQueue.java:709) at java.awt.EventQueue$3.run(EventQueue.java:703) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74) at java.awt.EventQueue.dispatchEvent(EventQueue.java:728) at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93) at java.awt.EventDispatchThread.run(EventDispatchThread.java:82) Caused by: org.diylc.netlist.TreeException: Could not find anything connected to a jack tip terminal. at org.diylc.netlist.GuitarDiagramAnalyzer.constructTree(GuitarDiagramAnalyzer.java:364) at org.diylc.netlist.GuitarDiagramAnalyzer.summarize(GuitarDiagramAnalyzer.java:101) at org.diylc.netlist.NetlistAnalyzer.summarize(Unknown Source) at org.diylc.swing.ActionFactory$SummarizeNetlistAction$1.doInBackground(Unknown Source) at org.diylc.swing.ActionFactory$SummarizeNetlistAction$1.doInBackground(Unknown Source) at org.diylc.swing.gui.MainFrame$6.doInBackground(Unknown Source) at javax.swing.SwingWorker$1.call(SwingWorker.java:295) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at javax.swing.SwingWorker.run(SwingWorker.java:334) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:750)

— Reply to this email directly, view it on GitHub https://github.com/bancika/diy-layout-creator/issues/794#issuecomment-1774245131, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXONCMMLVH2YO3HKN3TMR3YAWZVDAVCNFSM6AAAAAA4JLFLWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUGI2DKMJTGE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Branislav Stojkovic www.diy-fever.com

DeltaPotential commented 6 months ago

@bancika, thank you for kindly offering to take a look. I've attached the diagram.

This is my first foray into guitar wiring and switches, so it is possible that I have made a mistake. However, I was able to reproduce the issue with @PenBach's file too.

I noticed the ground connections don't "stick" to the pots or metal plate of the 5-way switch in the diagram. Is that expected?

Ibanez WIring - As Bought.diy.txt

DeltaPotential commented 5 months ago

I'd greatly appreciate if anyone could take a look and let me know if I made a mistake.

FlounderJr commented 2 weeks ago

I'm having the same issue with the error: "org.diylc.netlist.TreeException: Could not find anything connected to a jack tip terminal"

Additionally, I have this question as well: "I noticed the ground connections don't "stick" to the pots or metal plate of the 5-way switch in the diagram."

Has anyway resolved these?