bancika / diy-layout-creator

multi platform circuit layout and schematic drawing tool
http://diy-fever.com
GNU General Public License v3.0
854 stars 99 forks source link

Highlighted Connected Areas tool connects over a cut in a vero strip #804

Open visuttaja opened 5 months ago

visuttaja commented 5 months ago

I wonder if it was possible to make Highlighted Connected Areas tool take those cuts in vero strips in to consideration. That would be super helpful way to debug the composition. Currently the tool jumps over the cuts creating new connections which are not there. That kind of makes me more confused and I think I do better job just trying to check it out hundreds of times like I have always done. It would create a huge time saver if the algo was able to terminate the tracing at the cut. I insert a screeen shot where I tried to follow the positive power rail of the step up board output. HighlightedAreas

bancika commented 5 months ago

Hi, can you please upload the DIY file you have a problem with (renaming it to TXT)? This should work, so it must be a bug

On Mon, Dec 4, 2023 at 7:41 AM Guster Beaton @.***> wrote:

I wonder if it was possible to make Highlighted Connected Areas tool take those cuts in vero strips in to consideration. That would be super helpful to way to debug the composition. Currently the tool jumps over the cuts creating new connections which are not there. That kind of makes me more confused and I think I do better job just trying to check it out hundreds of times like I have always done. It would create a huge time saver if the algo was able to terminate the tracing at the cut. I insert a screeen shot where I tried to follow the positive power rail of the step up board output. HighlightedAreas.PNG (view on web) https://github.com/bancika/diy-layout-creator/assets/25703403/1081ff17-eb02-4019-9059-d47da43c7e6f

— Reply to this email directly, view it on GitHub https://github.com/bancika/diy-layout-creator/issues/804, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXONCNFSLKDE7GPIF44DBDYHVWCHAVCNFSM6AAAAABAFOWSI6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZDGMJUGAYDSNQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Branislav Stojkovic www.diy-fever.com

visuttaja commented 5 months ago

Ok. Here goes... HP_amp_given_dual_rail.txt

visuttaja commented 5 months ago

I think I accidentally found the simplest way to reproduce the issue! There is 13 steps. 1.Start DIYLC from disk as sole instance. 2.Insert a veroboard 3.Insert a trace cut on a strip. 4.Turn on HCA. 5.Press on the strip with cut. HCA works as expected. 5.Turn off the HCA.(this should wipe the connections off....it doesn't which could be part of the issue) 6.Select the board and start editing it from working area(right click -> Edit Selection). 7.Change Coordinate Origin of the board to any other value. 8.Turn on HCA. 9.Press on the strip with cut. Now you should get: SimplestVeroBoardTracejump

  1. Turn off the HCA.
  2. Move the cut.
  3. Turn on HCA.
  4. HCA works again.
visuttaja commented 5 months ago

So current workaround is to turn off HCA and move any of the elements on vero when editing is again possible. Then after reengaging HCA it works as expected.