search

bancodobrasil / stop-analyzing-api

Stop Analyzing API is the core module of Tinder like tool to help your customers make up their mind with no pain
MIT License
22 stars 17 forks source link

Run go test before each commit or show a console log to run go test before push #19

Closed eniovalo closed 4 years ago

eniovalo commented 4 years ago

Hi,

We could configure to run go test on all project before each commit to validate if the changings break anything. Or if tests are too slow, we could display a console log after commit to remember to run go test before push. =]

What do you think?

zamariola commented 4 years ago

It's a good point. We can configure the travis-ci and the goreportcard. btw, ours is A+ https://goreportcard.com/report/github.com/bancodobrasil/stop-analyzing-api

tiagostutz commented 4 years ago

Nice.!

Could we offer this issue to Rafamarts, at #12? Including the go test feature and the travis-ci thing.

What do you think?

eniovalo commented 4 years ago

@tiagostutz , I think It's ok. 🙂

eniovalo commented 4 years ago

It's a good point. We can configure the travis-ci and the goreportcard. btw, ours is A+ https://goreportcard.com/report/github.com/bancodobrasil/stop-analyzing-api

@zamariola , I didn't know this site, it is really nice to see the reports. Thanks. 🙂

rafamarts commented 4 years ago

Hi guys,

Please, assign to me. I can work on that..

Thank you!

tiagostutz commented 4 years ago

Nice! Assigned to you, @rafamarts!! Go for it.!

paulo-vieira-centeno commented 4 years ago

I'd like to help with this issue. Can you assign it to me?

tiagostutz commented 4 years ago

Done! Go for it @paulo-vieira-centeno !!

@rafamarts I assigned to @paulo-vieira-centeno and we will work on another issue soon, ok? Thanks!!

paulo-vieira-centeno commented 4 years ago

@tiagostutz , I was thinking in writing a bash script that performs some of the steps described in README.md file, except for the steps related to the build of the API. These steps would be done in the host machine, so it would make it easier to start developing/testing the API locally. We could also setup the githooks as one of these steps. What do you think about?

tiagostutz commented 4 years ago

Hi @paulo-vieira-centeno !

Sounds good to me! Please, go ahead. 🚀

paulo-vieira-centeno commented 4 years ago

@tiagostutz , I've already done my local changes in a local branch. I tried to push that branch to github, but got a '403 forbidden'. Can you give me the appropriate permissions to be able to push my branch to the repository?

eniovalo commented 4 years ago

Hi @paulo-vieira-centeno , I think you need to fork the project and after send a Pull Request. =] Like in this article and here there is more information.

paulo-vieira-centeno commented 4 years ago

Thanks for the instructions, @eniovalo

eniovalo commented 4 years ago

@paulo-vieira-centeno , you're welcome. 🙂