search

bancolombia / dart-code-linter

Dart Code Linter is a software analytics tool that helps developers analyse and improve software quality. Dart Code Linter is based on a fork of Dart Code Metrics. We welcome contributions from other developers. Please feel free to submit pull-requests and bugreports to this GitHub repository.
https://dcl.apps.bancolombia.com/
MIT License
45 stars 31 forks source link

Remove prefer-commenting-analyzer-ignores #160

Open ngoc-quoc-huynh opened 1 week ago

ngoc-quoc-huynh commented 1 week ago

Since Dart introduced document_ignores, I think we can remove prefer-commenting-analyzer-ignores. What do you think?

app-toolkit-opensource-innersource[bot] commented 1 week ago

Assign to review: @santitigaga @ajtortolero

santitigaga commented 4 days ago

@ngoc-quoc-huynh it's a good idea, but this rule is only available after dart 3.5. I'm sure than a lot of projects using DCL are using older versions. Whatever we can reference this dart rule in the DCL doc, and announce the deprecation of this rule in future releases.

Your help in adjusting this is appreciated. 💯

ngoc-quoc-huynh commented 1 day ago

@santitigaga where and how can I mark this rule as deprecated and adjust the docs?