bancorprotocol / carbon-app

https://app.carbondefi.xyz
MIT License
24 stars 19 forks source link

[Edit Price] Add edit budget #1299

Closed GrandSchtroumpf closed 2 months ago

GrandSchtroumpf commented 3 months ago

Disposable Edit Price: image

Recurring Edit Price: image

cloudflare-workers-and-pages[bot] commented 3 months ago

Deploying carbon-app-sei with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8c6d57f
Status: ✅  Deploy successful!
Preview URL: https://4fe95265.carbon-app-sei.pages.dev
Branch Preview URL: https://issue--1264-ter.carbon-app-sei.pages.dev

View logs

cloudflare-workers-and-pages[bot] commented 3 months ago

Deploying carbon-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8c6d57f
Status: ✅  Deploy successful!
Preview URL: https://d3573d50.carbon-app-csq.pages.dev
Branch Preview URL: https://issue--1264-ter.carbon-app-csq.pages.dev

View logs

Costa769 commented 3 months ago

For both recurring and disposable strategies, if user:

  1. Clicks on edit prices
  2. Enters deposit/withdraw amount in one or both budget fields
  3. No prices are edited, or strategy type changed and no warning messages are displayed

Expected:

Actual:

Costa769 commented 3 months ago

Move order type selection below the token pair on edit price page

image
Costa769 commented 3 months ago

Go to disposable strategy edit prices page without making any change to prices/budgets or or order type

Expected: CTA is disabled Actual: CTA is enabled

Costa769 commented 2 months ago

The following should be appplied only to edit prices page on disposable order tab

On edit prices disposable tab page load:

IF the inactive order budget !=0 (note that inactive order budget refers to the budget of an order that is being removed due to the order type change or the budget gained from the execution of a disposable order):

ELSE:

Do not display a warning text.