search

bancorprotocol / carbon-app

https://app.carbondefi.xyz
MIT License
23 stars 14 forks source link

[BUG] No approval re-request for consecutive trades using limited approval #1302

Closed tiagofilipenunes closed 3 weeks ago

tiagofilipenunes commented 3 weeks ago

How to reproduce:

  1. Trade an amount of an ERC-20 on the trade page
  2. When showed the approval modal, approve 'Limited' (default on Sei)
  3. Swap
  4. Once 3) confirms, attempt to swap the same ERC-20 and same amount again
  5. The approval modal does not show and the transaction fails

https://github.com/bancorprotocol/carbon-app/assets/66181828/1efbc1b7-613e-41d7-9106-88f1a45de19c

Reproduced on Chrome 126.0.6478.63 / MacOS 14.5