bancorprotocol / carbon-app

https://app.carbondefi.xyz
MIT License
23 stars 14 forks source link

Overlapping strategy - Price update on withdraw/deposit #1315

Open Costa769 opened 3 weeks ago

Costa769 commented 3 weeks ago

Overview

When a user makes a withdrawal or deposit on the overlapping strategy edit price page without altering the strategy prices or spread, the activity table displays the action as "edit price," indicating that the price was updated.

How to reproduce:

1- Select overlapping strategy with the external market price inside the price range 2- Go to "Edit prices" page 2- Partially withdraw both budgets without changing the price range or spread

Expected: 1- In the API response there is no indication that the prices were changed 2- Action type in the API response is "Withdraw" 3- Activity table display "Withdraw" action

Actual: 1- In the API response there is an indication that the prices were changed 2- Action type returned by the API is "Edit" 3- Activity table display "Edit Price" action

image