[Overlapping] Graph uses external market price

[GrandSchtroumpf]

fix #1320

Strategy with external market price:

Strategy without external market price

Note: The text is "Geometric mean", while it's not exactly that when strategy is above/below market. Maybe use "Calculated market price".

Strategy with user market price

Switching from untouched to touch changes the marginal price: https://github.com/bancorprotocol/carbon-app/assets/8143464/ce548f8d-c799-4b85-bec0-4783b09133e3

[cloudflare-pages[bot]]

Deploying carbon-app-sei with    Cloudflare Pages

Latest commit:	bea1be0
Status:	✅  Deploy successful!
Preview URL:	https://e7a2bb25.carbon-app-sei.pages.dev
Branch Preview URL:	https://issue--1320.carbon-app-sei.pages.dev

View logs

[cloudflare-pages[bot]]

Deploying carbon-app with    Cloudflare Pages

Latest commit:	bea1be0
Status:	✅  Deploy successful!
Preview URL:	https://261f0c31.carbon-app-csq.pages.dev
Branch Preview URL:	https://issue--1320.carbon-app-csq.pages.dev

View logs

[ashachaf]

• [ ] edit price - do not default into price field when price is available flow:
  1. click edit price
  2. IF external price is available, do not default into the price field (because it force to show the last bit of the price which is usually a number that doesnt make sense)

https://github.com/bancorprotocol/carbon-app/assets/40430285/2ddb9d14-cc1a-466a-bbe1-5b931647f31b

• [x] external price - decimal trim currently, we show 82 decimals. updated, show the following: IF (first 6 decimals are 0) AND (price < 1), show the 6 decimals after the first non zero digit ELSE, show 6 decimals

• [ ] edit market price when there is no external price currently warning: Warning, your market price will be used in the strategy creation flow and calculations.

updated warning: Warning, the defined market price will be used for strategy budget distribution

• [ ] edit strategy with no external price flow:
  1. edit a strategy with no external price
  2. show the price input modal
  3. in the place where we typically show "use market" and allow users to click and use the external market price, replace it with "use strategy" and allow users to click and use the strategy geomean(marginal.sell, marginal.buy)
  4. add tool tip when mouse over "use strategy" with this text: "This price is the geometric mean of the strategy buy and sell marginal prices."

[Costa769]

• [x] Updating prices on the graph

flow:

1. Find concentrated strategy without market price
2. Click edit prices
3. Chage the prices via the graph without providing the market price

Expected: User can't update the prices

Actual: User can change the prices of the strategy

• [x] Deposit/withdraw from a strategy without market price

flow:

1. Find concentrated strategy without market price
2. Click edit prices
3. Select one of the tokens and click on edit budget without providing the market price
4. Input deposit amount
5. Click the checkbox

Expected: CTA becomes enabled

Actual: CTA is disabled and becomes enabled only after user sets the market price

[ashachaf]

• [x] Using external market cap for deposit/withdraw incorrectly Flow:
• edit concentrated strategy with market price
• click to withdraw some tokens (no other changes) expected: withdraw from the strategy according to the on-chain marginal price actual: the check is using the current market price and tried to re-adjust the strategy around it

[ashachaf]

• [x] text change current: {token} market price is missing. To continue the prices of the strategy, enter its market price below.

updated: {token} market price is missing. Please provide the market price to enable price editing.

[Costa769]

• [x] Difference from market price indicators

Current: We always display difference from market price indicators below the strategy price points, regardless of the presence or absence of a market price. Updated: Show difference from market price indicators only when there is an external market price or market price that was provided by the user. Otherwise, show only the price points without the difference from market price indicators

[GrandSchtroumpf]

Manually tested with :

1. Create an overlapping strategy with tokens with market price
2. Trade against it
3. Go to edit price, the graph should display external market price, but marginal price is the current one from the strategy
4. Try to withdraw without change price or spread, it should use the calculated market price

5. Withdraw

6. Create an overlapping strategy with tokens without market price
7. Trade against it
8. Go to edit price, the graph should be disabled (you cannot change the price), and the price section is hidden
9. Withdraw -> it should use calculated market price
10. Go back to edit price, enter a market price in the input field -> the graph should be enabled and price is available
11. Withdraw -> it should use the market price you filled in the input